Add all writeable properties to TypeProperties cache #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This catches any writeable property, including internal properties that were previously ignored
|
Please let me know if there's a reason why public properties only are better. I'd also be happy to add in a check here that throws when 0 properties are found and some tests around this behaviour |
Binding flags filter still pulls back private properties, this prevents those properties from being mapped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This catches any writeable property, including internal properties that were previously ignored.
This caught me out because my I created my table models as internal models (which I think is the default now if you're working in VS 2022?) to prevent dependant projects from trying to use them, and only after debugging Dapper.Contrib locally did I realise that only the public properties were being mapped to column names.
For reference here's the error message I was seeing when calling InsertAsync on my internal model:
And the SQL it generated to cause this was:
INSERT INTO dbo.my_table () values (); SELECT SCOPE_IDENTITY() id